bpo-47128: Enhance Argument Clinic's NoneType return converter to give void
#32126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following possible (note that the impl has a void return type):
Previously, the return type would be
Object *
and a caller would replace non-Py_None
values with NULL.So now there is no need to track whether
NULL
orPy_None
should be returned. Or should it bePy_RETURN_NONE
? Argument Clinic does it by itself returning NULL on errors and Py_None otherwise:https://bugs.python.org/issue47128