Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46662: Fix convert_timestamp function that failed to correctly parse timestamp #31169

Closed
wants to merge 3 commits into from

Conversation

Rayologist
Copy link

@Rayologist Rayologist commented Feb 6, 2022

This change fixes convert_timestamp() function by splitting timezone information and time

https://bugs.python.org/issue46662

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Rayologist

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 8, 2022

If this is to be applied, we need test cases for it and a NEWS entry.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@Rayologist Rayologist closed this Aug 31, 2022
@erlend-aasland
Copy link
Contributor

The default converters and adapters were deprecated in gh-90016. This implies we won't accept this PR, but thank you nonetheless for your interest in improving CPython! We added recipes for common converters and adapters to the sqlite3 docs. You might want to take a look at those.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants