Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46564: do not create frame object for super object #31002

Merged
merged 5 commits into from
Feb 1, 2022
Merged

bpo-46564: do not create frame object for super object #31002

merged 5 commits into from
Feb 1, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 29, 2022 •
edited by bedevere-bot
Loading

@kumaraditya303 kumaraditya303 changed the title do not create frame object for super bpo46564: do not create frame object for super object Jan 29, 2022
@kumaraditya303 kumaraditya303 changed the title bpo46564: do not create frame object for super object bpo-46564: do not create frame object for super object Jan 29, 2022
@kumaraditya303 kumaraditya303 marked this pull request as ready for review January 29, 2022 04:59
@Fidget-Spinner
Copy link
Member

Marking DO-NOT-MERGE as it's already part of #30992. There's more discussion about this on the issue tracker.

@markshannon markshannon mentioned this pull request Jan 29, 2022
Closed
Fidget-Spinner
Fidget-Spinner reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a short news entry. I'll merge after that.

Objects/typeobject.c Outdated Show resolved Hide resolved
@Fidget-Spinner Fidget-Spinner merged commit b9ebde8 into python:main Feb 1, 2022
@Fidget-Spinner
Copy link
Member

Thanks!

@kumaraditya303 kumaraditya303 deleted the super branch February 2, 2022 04:36
@Fidget-Spinner Fidget-Spinner mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot