Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45229: Revert "Make datetime tests discoverable" #28650

Merged
merged 1 commit into from
Sep 30, 2021
Merged

bpo-45229: Revert "Make datetime tests discoverable" #28650

merged 1 commit into from
Sep 30, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 30, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Sep 30, 2021
@pablogsal
Copy link
Member Author

Temporary revert of #28615 until we have a fix for the buildbot fleet

@pablogsal pablogsal requested review from vstinner and ambv September 30, 2021 12:22
vstinner
vstinner approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Serhiy's enhancement is great, but breaking all Refleaks buildbot is reason good enough to justify a revert.

It seems like it's simple to reproduce the issue, so we can revert and investigate on our side in the meanwhile.

@pablogsal pablogsal merged commit b07fddd into main Sep 30, 2021
@pablogsal pablogsal deleted the revert-28615-test-datetime-discover branch September 30, 2021 13:46
serhiy-storchaka added a commit that referenced this pull request Oct 1, 2021
@serhiy-storchaka
Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…
47099cf 
…" (GH-28650)"

This reverts commit b07fddd.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 1, 2021
Merged
serhiy-storchaka added a commit that referenced this pull request Oct 1, 2021
@serhiy-storchaka
Revert "Revert "bpo-45229: Make datetime tests discoverable (GH-28615)…
2f20592 
…" (GH-28650)" (GH-28667)

This reverts commit b07fddd.
@serhiy-storchaka serhiy-storchaka mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle pganssle approved these changes

@vstinner vstinner vstinner approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @vstinner @pganssle @the-knights-who-say-ni @bedevere-bot