Fix references to methods attr
#26806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/crypt.rst
Outdated
| @@ -93,7 +93,7 @@ The :mod:`crypt` module defines the following functions: | |||
| may be available on all platforms), or a full encrypted password | |||
| including salt, as returned by this function. If *salt* is not | |||
| provided, the strongest method will be used (as returned by | |||
There was a problem hiding this comment.
If methods is not a function, do we need the wording as returned by ? We usually use return for results of functions and methods. Am assuming due diligence, that methods is actually an attribute, not a method, therefore someone else can confirm on this.
|
Yep, methods is just a simple python list in fact, I will update the
wording..
…On Tue, Jun 22, 2021 at 8:58 AM Joannah Nanjekye ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Doc/library/crypt.rst
<#26806 (comment)>:
> @@ -93,7 +93,7 @@ The :mod:`crypt` module defines the following functions:
may be available on all platforms), or a full encrypted password
including salt, as returned by this function. If *salt* is not
provided, the strongest method will be used (as returned by
If methods is not a function, do we need the wording as returned by ? We
usually use return for results of functions and methods. Am assuming due
diligence, that methods is actually an attribute, not a method, therefore
someone else can confirm on this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26806 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB3RIVW766O2V2LARPJZSLTUCCF3ANCNFSM467OMZVA>
.
|
JelleZijlstra
added
needs backport to 3.9
JelleZijlstra
approved these changes
Apr 5, 2022
|
Thanks @akulakov for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-32324 is a backport of this pull request to the 3.10 branch. |
bedevere-bot
removed
needs backport to 3.10
|
GH-32325 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 5, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit cae0f5d) Co-authored-by: andrei kulakov <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 5, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit cae0f5d) Co-authored-by: andrei kulakov <[email protected]>
|
@JelleZijlstra thanks for reviewing! |
miss-islington
added a commit
that referenced
this pull request
Apr 5, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit cae0f5d) Co-authored-by: andrei kulakov <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 5, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit cae0f5d) Co-authored-by: andrei kulakov <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit cae0f5d) Co-authored-by: andrei kulakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.