Note the buffer slots can be set with PyType_Spec with the unlimited … #22031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
added
skip issue
skip news
needs backport to 3.7
needs backport to 3.9
alex
approved these changes
Aug 31, 2020
alex
approved these changes
Aug 31, 2020
corona10
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
@benjaminp Please rebase your branch, it will solve the docs failure.
alex
reviewed
Sep 1, 2020
| @@ -239,6 +240,10 @@ The following functions and structs are used to create | |||
| (see :ref:`PyMemberDef <pymemberdef-offsets>`) | |||
| * :c:member:`~PyTypeObject.tp_vectorcall_offset` | |||
| (see :ref:`PyMemberDef <pymemberdef-offsets>`) | |||
|
|
|||
| The following fields cannot be set using :c:type:`PyType_Spec` and | |||
There was a problem hiding this comment.
Should this contain a versionchanged annotation?
…API. Follow up to f7c4e23.
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 2, 2020
…API. (pythonGH-22031) Follow up to f7c4e23. (cherry picked from commit 700fa1b) Co-authored-by: Benjamin Peterson <[email protected]>
|
GH-22052 is a backport of this pull request to the 3.9 branch. |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
…API. (pythonGH-22031) Follow up to f7c4e23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…API.