bpo-38992: avoid fsum test failure from constant-folding #17513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Dec 9, 2019
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 9, 2019
) * Issue 38992: avoid fsum test failure * Add NEWS entry (cherry picked from commit bba873e) Co-authored-by: Mark Dickinson <[email protected]>
|
GH-17530 is a backport of this pull request to the 3.8 branch. |
mdickinson
added a commit
that referenced
this pull request
Dec 9, 2019
…H-17530) * Issue 38992: avoid fsum test failure * Add NEWS entry (cherry picked from commit bba873e) Co-authored-by: Mark Dickinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tentative fix for the issue described at https://bugs.python.org/issue38992. One of the tests
for
math.fsumwas failing on a cross-compiled Python, due to two different values of a constant (1.7**1000) being used.The change in this PR ensures that each power of
1.7used in thefsumtest is only computed once, so that there's no danger of using two different values of1.7**1000.https://bugs.python.org/issue38992