Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36743: __get__ is sometimes called without the owner argument #12992

Merged
merged 5 commits into from
Aug 29, 2019
Merged

bpo-36743: __get__ is sometimes called without the owner argument #12992

merged 5 commits into from
Aug 29, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Apr 28, 2019 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news needs backport to 3.7 labels Apr 28, 2019
@jdufresne
Copy link
Contributor

Would it make sense to update the signature line to?

.. method:: object.__get__(self, instance, owner=None)

jdemeyer
jdemeyer requested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained on bpo-36743, the text "Note that callers are allowed to omit the owner argument when it isn't needed." is not actually true in general, or trivially true depending on how you interpret "isn't needed".

@rhettinger rhettinger force-pushed the descr_get_optional_owner branch from 67289b1 to f312558 Compare August 29, 2019 07:07
@rhettinger rhettinger merged commit 0dac68f into python:master Aug 29, 2019
@rhettinger rhettinger deleted the descr_get_optional_owner branch August 29, 2019 08:27
@bedevere-bot
Copy link

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15589 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
@rhettinger @miss-islington
bpo-36743: __get__ is sometimes called without the owner argument (py…
d604227 
…thonGH-12992)

(cherry picked from commit 0dac68f)

Co-authored-by: Raymond Hettinger <[email protected]>
rhettinger added a commit that referenced this pull request Aug 29, 2019
@miss-islington @rhettinger
bpo-36743: __get__ is sometimes called without the owner argument (GH…
c71ae1a 
…-12992) (GH-15589)

(cherry picked from commit 0dac68f)

Co-authored-by: Raymond Hettinger <[email protected]>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
bpo-36743: __get__ is sometimes called without the owner argument (py…
31ea128 
…thon#12992)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-36743: __get__ is sometimes called without the owner argument (py…
b459c10 
…thon#12992)
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
bpo-36743: __get__ is sometimes called without the owner argument (py…
92e9819 
…thon#12992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemeyer jdemeyer jdemeyer requested changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhettinger @jdufresne @bedevere-bot @miss-islington @jdemeyer @the-knights-who-say-ni