Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-121970: Extract implementation_detail into a new extension #129663

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Feb 4, 2025

I've tested both HTML and gettext output, both identical (given SOURCE_DATE_EPOCH is set).

The run() function is rewritten for clarity, and we sort the translation strings in dummy.html.

A


📚 Documentation preview 📚: https://cpython-previews--129663.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Feb 4, 2025
@AA-Turner AA-Turner requested a review from hugovk as a code owner February 4, 2025 16:58
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AA-Turner AA-Turner enabled auto-merge (squash) February 6, 2025 16:48
@AA-Turner AA-Turner merged commit 4d56c40 into python:main Feb 6, 2025
23 of 24 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d56c40440c9fd4499d61d24977336d8cd8d8d83 3.13

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d56c40440c9fd4499d61d24977336d8cd8d8d83 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 6, 2025
…extension (pythonGH-129663)

(cherry picked from commit 4d56c40)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2025

GH-129739 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 6, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 6, 2025
…extension (pythonGH-129663)

(cherry picked from commit 4d56c40)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 6, 2025

GH-129740 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 6, 2025
@AA-Turner AA-Turner deleted the docs/implementation-detail branch February 6, 2025 17:26
AA-Turner added a commit that referenced this pull request Feb 6, 2025
AA-Turner added a commit that referenced this pull request Feb 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants