gh-104400: Remove fintl.gettext from pygettext
#129580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintl is never installed or tested, so the fallback is unconditionally used. This means we can simplify, converting the docstring to a real docstring, and converting some other strings to f-strings
AA-Turner
changed the title
fintl.gettext from pygettext
AA-Turner
commented
Feb 2, 2025
This has not been updated since 2002, the git history can be used
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
The ``fintl`` module is never installed or tested, meaning that the fallback identity function is unconditionally used for ``_()``. This means we can simplify, converting the docstring to a real docstring, and converting some other strings to f-strings. We also convert the module to UTF-8, sort imports, and remove the history comment, which was last updated in 2002. Consult the git history for a more accurate summary of changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fintlmodule is never installed or tested, meaning that thefallback identity function is unconditionally used for
_().This means we can simplify, converting the docstring to a real
docstring, and converting some other strings to f-strings.
We also convert the module to UTF-8, sort imports,
and remove the history comment, which was last updated in 2002.
Consult the git history for a more accurate summary of changes.
The code was introduced in c8f0892, but unchanged since. There is no fintl package on PyPI.
This page references a Sourceforge page which is HTTP 404, but does exist on the WayBack Machine (latest working link from 2003!), so safe to say this code is long-unused -- the copyright & posting dates are before Python 2 was released in October 2000.