Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-129438: Update --enable-experimental-jit section with install requirements #129450

Merged
merged 4 commits into from
Jan 30, 2025
Merged

gh-129438: Update --enable-experimental-jit section with install requirements #129450

merged 4 commits into from
Jan 30, 2025
+7 −1

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Jan 29, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Jan 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 29, 2025
Closed
Eclips4
Eclips4 requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a similar note to Tools/jit/README.md

@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jan 29, 2025

Thanks for making the requested changes!

@Eclips4: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from Eclips4 January 29, 2025 20:20
@StanFromIreland
Copy link
Contributor Author

I accidentally included an auto lint change. (Removed whitespace) I think its fine to include?

Eclips4
Eclips4 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Jan 29, 2025
@Eclips4 Eclips4 requested a review from picnixz January 29, 2025 20:49
brandtbucher
brandtbucher approved these changes Jan 29, 2025
View reviewed changes
Tools/jit/README.md Outdated Show resolved Hide resolved
@StanFromIreland @brandtbucher
Update Tools/jit/README.md
43b1d16 
Co-authored-by: Brandt Bucher <[email protected]>
@Eclips4 Eclips4 merged commit 652f66a into python:main Jan 30, 2025
31 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2025
@StanFromIreland @brandtbucher @miss-islington
pythongh-129438: Update --enable-experimental-jit section with in…
1f2533e 
…stall requirements (pythonGH-129450)

Add a note to the `JIT` docs that building CPython with `JIT` requires Python 3.11 or newer.

(cherry picked from commit 652f66a)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2025

GH-129472 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 30, 2025
Eclips4 pushed a commit that referenced this pull request Jan 30, 2025
@miss-islington @StanFromIreland @brandtbucher
[3.13] gh-129438: Update --enable-experimental-jit section with i…
fcb2656 
…nstall requirements (GH-129450) (#129472)

gh-129438: Update ``--enable-experimental-jit`` section with install requirements (GH-129450)

Add a note to the `JIT` docs that building CPython with `JIT` requires Python 3.11 or newer.

(cherry picked from commit 652f66a)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@picnixz picnixz Awaiting requested review from picnixz

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanFromIreland @Fidget-Spinner @brandtbucher @Eclips4