Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91417: Remove PySequence_Fast() from the limited C API #129398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-91417: Remove PySequence_Fast() from the limited C API #129398

wants to merge 1 commit into from
+35 −26

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 28, 2025 •
edited by github-actions bot
Loading

The function never worked with the limited C API. It was added by mistake.

📚 Documentation preview 📚: https://cpython-previews--129398.org.readthedocs.build/

@vstinner
pythongh-91417: Remove PySequence_Fast() from the limited C API
6500fe7 
The function never worked with the limited C API. It was added by
mistake.
@vstinner vstinner requested a review from encukou as a code owner January 28, 2025 12:21
@bedevere-app bedevere-app bot mentioned this pull request Jan 28, 2025
Open
@vstinner
Copy link
Member Author

cc @serhiy-storchaka

@vstinner
Copy link
Member Author

cc @encukou

serhiy-storchaka
serhiy-storchaka approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this should be discussed within the C API Workgroup.

@vstinner
Copy link
Member Author

this should be discussed within the C API Workgroup.

Ok, I created capi-workgroup/decisions#55 discussion.

@vstinner vstinner mentioned this pull request Jan 29, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @serhiy-storchaka