Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing #129339

Merged
merged 1 commit into from
Jan 27, 2025
Merged

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing #129339

merged 1 commit into from
Jan 27, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 27, 2025 •
edited by github-actions bot
Loading

It's convenient to be able to call PyLongWriter_Discard(NULL) in error handling code.

📚 Documentation preview 📚: https://cpython-previews--129339.org.readthedocs.build/

@vstinner
pythongh-102471: Change PyLongWriter_Discard(NULL) to do nothing
e3ed89b 
It's convenient to be able to call PyLongWriter_Discard(NULL) in
error handling code.
@bedevere-app bedevere-app bot mentioned this pull request Jan 27, 2025
Open
@vstinner
Copy link
Member Author

cc @skirpichev

Make PyLongWriter_Discard(NULL) similar to PyUnicodeWriter_Discard(NULL): do nothing.

@vstinner vstinner enabled auto-merge (squash) January 27, 2025 10:44
@vstinner vstinner merged commit 7ec1742 into python:main Jan 27, 2025
46 checks passed
@vstinner vstinner deleted the long_discard branch January 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @skirpichev