gh-75955: tarfile: Allow configuring the record size #129260
Open
+64
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Jan 24, 2025
| def __init__(self, name=None, mode="r", fileobj=None, format=None, | ||
| tarinfo=None, dereference=None, ignore_zeros=None, encoding=None, | ||
| errors="surrogateescape", pax_headers=None, debug=None, | ||
| errorlevel=None, copybufsize=None, stream=False): | ||
| errorlevel=None, copybufsize=None, stream=False, | ||
| blocking_factor=None): |
There was a problem hiding this comment.
Instead of None, should the blocking_factor default to 20, or a constant BLOCKING_FACTOR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuring the record size of a tarfile from the default of 20, as requested in #75955, by adding a new optional parameter blocking_factor to
tarfile.TarFile. This matches the--blocking-factorparameter supported by GNU tar.The
blocking_factoris only used to influence the padding when writing to an archive, just as the previously hard coded blocking factor of 20.📚 Documentation preview 📚: https://cpython-previews--129260.org.readthedocs.build/