Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-71339: Use new assertion methods in test_idle (GH-129213) #129237

Closed
wants to merge 1 commit into from
Closed

[3.13] gh-71339: Use new assertion methods in test_idle (GH-129213) #129237

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 23, 2025 •
edited by bedevere-app bot
Loading

Revise 10 tests in 7 files, with 1 test split into 2.
(cherry picked from commit dbb25ce)

Co-authored-by: Terry Jan Reedy [email protected]

@terryjreedy @miss-islington
pythongh-71339: Use new assertion methods in test_idle (pythonGH-129213)
18e3cfb 
Revise 10 tests in 7 files, with 1 test split into 2.
(cherry picked from commit dbb25ce)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app bedevere-app bot mentioned this pull request Jan 23, 2025
Merged
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jan 23, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 23, 2025
Open
@terryjreedy terryjreedy enabled auto-merge (squash) January 23, 2025 18:27
serhiy-storchaka
serhiy-storchaka reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add from test.support.testcase import ExtraAssertions at the top of the files and then mix ExtraAssertions into classes that use new methods.

@serhiy-storchaka serhiy-storchaka marked this pull request as draft January 23, 2025 18:38
auto-merge was automatically disabled January 23, 2025 18:38

Pull request was converted to draft

@terryjreedy
Copy link
Member

Thanks. Will try to get back to this tomorrow.

@terryjreedy
Copy link
Member

Replaced by #129314 (because I forgot that I could modify this miss-islington PR the same as a person's).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @terryjreedy @serhiy-storchaka