Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-129044: Update glossary entry for 'loader' to reflect current import system #129073

Merged
merged 6 commits into from
Jan 20, 2025
Merged

gh-129044: Update glossary entry for 'loader' to reflect current import system #129073

merged 6 commits into from
Jan 20, 2025

Conversation

nikalinov
Copy link
Contributor

@nikalinov nikalinov commented Jan 20, 2025 •
edited by github-actions bot
Loading

Edited Glossary documentation, 'loader' part to reflect the current version

📚 Documentation preview 📚: https://cpython-previews--129073.org.readthedocs.build/

@cpython-cla-bot CPython CLA Bot

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jan 20, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 20, 2025
Closed
AA-Turner
AA-Turner requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this simple, we can link to the documentation that describes the deprecation.

Note that you don't need to keep this branch up-to-date unless there are merge conflicts.

A

Doc/glossary.rst Outdated Show resolved Hide resolved
Doc/glossary.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AA-Turner AA-Turner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jan 20, 2025
@nikalinov
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from AA-Turner January 20, 2025 15:22
AA-Turner
AA-Turner reviewed Jan 20, 2025
View reviewed changes
Doc/glossary.rst Outdated Show resolved Hide resolved
@AA-Turner
Copy link
Member

Congratulations! You improved:
Doc/glossary.rst
Please remove from Doc/tools/.nitignore

@nikalinov could you remove the glossary entry from Doc/tools/.nitignore please?

A

@AA-Turner AA-Turner merged commit e1fa2fc into python:main Jan 20, 2025
24 checks passed
@miss-islington-app
Copy link

Thanks @nikalinov for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 20, 2025
@nikalinov @AA-Turner @miss-islington
pythongh-129044: Update glossary entry for 'loader' to reflect curren…
4bf38dd 
…t import system (pythonGH-129073)

(cherry picked from commit e1fa2fc)

Co-authored-by: nikalinov <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@miss-islington-app
Copy link

Sorry, @nikalinov and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e1fa2fcc7c1bf5291a7f71300b7828b49be9ab72 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jan 20, 2025

GH-129077 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 20, 2025
@nikalinov
Copy link
Contributor Author

Congratulations! You improved:
Doc/glossary.rst
Please remove from Doc/tools/.nitignore

@nikalinov could you remove the glossary entry from Doc/tools/.nitignore please?

A

Done, sorry for the mistakes as I am a beginning contributor.

@AA-Turner
Copy link
Member

Congratulations on your first PR @nikalinov! Would you be able to open the 3.12 backport?

No mistakes at all, Doc/tools/.nitignore is part of a long-running effort, and this removed the last remaining warning in the Glossary.

A

AA-Turner added a commit that referenced this pull request Jan 20, 2025
@miss-islington @nikalinov @AA-Turner
[3.13] gh-129044: Update glossary entry for 'loader' to reflect curre…
2f8eefe 
…nt import system (GH-129073) (#129077)

gh-129044: Update glossary entry for 'loader' to reflect current import system (GH-129073)
(cherry picked from commit e1fa2fc)

Co-authored-by: nikalinov <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@nikalinov
Copy link
Contributor Author

@AA-Turner I resolved the backport conflict locally on 3.12, should I open a pull request on 3.12?

@AA-Turner
Copy link
Member

cherry_picker should do so automatically, is it not working for you?

@nikalinov
Copy link
Contributor Author

I run the cherry_picker <commit> 3.12 and a new branch was created, not a pull request. Am I supposed to run some other commands for the PR? I see that I can just open it manually.

@AA-Turner
Copy link
Member

Ok, go ahead and open the PR -- make sure you select 3.12 as the base/target branch, though.

A

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
@nikalinov @AA-Turner @srinivasreddy
pythongh-129044: Update glossary entry for 'loader' to reflect curren…
158d998 
…t import system (python#129073)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 21, 2025

GH-129130 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 21, 2025
AA-Turner added a commit that referenced this pull request Jan 21, 2025
@nikalinov @AA-Turner
[3.12] gh-129044: Update glossary entry for 'loader' to reflect curre…
b849a1b 
…nt import system (#129073) (#129130)

* gh-129044: Update glossary entry for 'loader' to reflect current import system (#129073)

Co-authored-by: Adam Turner <[email protected]>
(cherry picked from commit e1fa2fc)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

@AA-Turner AA-Turner

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikalinov @AA-Turner