Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] Explicitly import urllib.error in urllib.robotparser (GH-128737) #128793

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

miss-islington
Copy link
Contributor

(cherry picked from commit 53e8942)

Co-authored-by: Bénédikt Tran [email protected]

…8737)

(cherry picked from commit 53e8942)

Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz
Copy link
Member

picnixz commented Jan 13, 2025

I'll wait for #128755 to be merged since we're modifying the same file.

@vstinner
Copy link
Member

I'll wait for #128755 to be merged since we're modifying the same file.

As you want, but I don't expect conflicts since they don't modify the same lines.

@picnixz
Copy link
Member

picnixz commented Jan 13, 2025

As you want, but I don't expect conflicts since they don't modify the same lines.

It was more to keep the same history change (but my CI is slower so I guess the other branch will be merged first even if I enable auto-merge for this one)

@picnixz picnixz merged commit 1079619 into python:3.13 Jan 13, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants