Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-77214: Update outdated documentation for numeric PyArg_Parse formats #128454

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 3, 2025

Doc/c-api/arg.rst Outdated Show resolved Hide resolved
Doc/c-api/arg.rst Outdated Show resolved Hide resolved
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording LGTM with a few nitpicks.
(I didn't check if the docs correspond to the actual behaviour; I trust you that they do.)

Doc/c-api/arg.rst Outdated Show resolved Hide resolved
Doc/c-api/arg.rst Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit 8d15058 into python:main Jan 6, 2025
24 of 25 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-c-api-numeric-formats branch January 6, 2025 10:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2025
… formats (pythonGH-128454)

(cherry picked from commit 8d15058)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2025
… formats (pythonGH-128454)

(cherry picked from commit 8d15058)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2025

GH-128538 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2025

GH-128539 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 6, 2025
serhiy-storchaka added a commit that referenced this pull request Jan 6, 2025
…e formats (GH-128454) (GH-128538)

(cherry picked from commit 8d15058)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jan 6, 2025
…e formats (GH-128454) (GH-128539)

(cherry picked from commit 8d15058)

Co-authored-by: Serhiy Storchaka <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants