gh-128330: Terminal control characters should be restored on repl exit #128331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
citrus-it
commented
Dec 29, 2024
•
citrus-it
commented
- Issue: Terminal settings are not correctly restored on repl exit #128330
citrus-it
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Misc/NEWS.d/next/Core_and_Builtins/2024-12-29-15-09-21.gh-issue-128330.IaYL7G.rst
Outdated
Show resolved
Hide resolved
ZeroIntensity
added
needs backport to 3.13
citrus-it
force-pushed
the
fancy_termios
branch
from
e720962 to
35f88f9
Compare
pablogsal
approved these changes
Jan 23, 2025
|
Thanks @citrus-it for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2025
…pl exit (pythonGH-128331) (cherry picked from commit 0b15d9c) Co-authored-by: Andy Fiddaman <[email protected]>
|
GH-129233 is a backport of this pull request to the 3.13 branch. |
Tripathi-Manjul
pushed a commit
to Tripathi-Manjul/cpython
that referenced
this pull request
Jan 23, 2025
|
This was merged without a test. Is it worth adding one in a follow-up? |
|
There is not an easy way to test this that I can think of (just checking that the list is not modified doesn't actually test the fix) but if you can think of one I am happy to review the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.