-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128192: mark new tests with skips based on hashlib algorithm availability #128324
gh-128192: mark new tests with skips based on hashlib algorithm availability #128324
Conversation
!buildbot FIPS |
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 485c117 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot FIPS |
🤖 New build scheduled with the buildbot fleet by @gpshead for commit bd4a172 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot Blake2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing it!
@@ -27,6 +27,7 @@ | |||
import urllib.error | |||
import http.client | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this was desired to be part of the diff.
… availability (pythongh-128324) Puts the _hashlib get_fips_mode logic check into test.support rather than spreading it out among other tests.
This is not important. The buildbot this is ameliorating is a crazy configuration that we don't support, primarily for testing purposes. This just tries to maintain pairity with which oddball bots were failing before the issues main change rather than regressing one.