Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128192: mark new tests with skips based on hashlib algorithm availability #128324

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Dec 29, 2024

This is not important. The buildbot this is ameliorating is a crazy configuration that we don't support, primarily for testing purposes. This just tries to maintain pairity with which oddball bots were failing before the issues main change rather than regressing one.

@gpshead gpshead self-assigned this Dec 29, 2024
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Dec 29, 2024
@gpshead
Copy link
Member Author

gpshead commented Dec 29, 2024

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 485c117 🤖

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR

@gpshead
Copy link
Member Author

gpshead commented Dec 29, 2024

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit bd4a172 🤖

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR

@gpshead
Copy link
Member Author

gpshead commented Dec 29, 2024

!buildbot Blake2

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit e454e42 🤖

The command will test the builders whose names match following regular expression: Blake2

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR

@gpshead gpshead requested a review from picnixz December 29, 2024 06:07
@gpshead gpshead marked this pull request as ready for review December 29, 2024 06:09
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing it!

@@ -27,6 +27,7 @@
import urllib.error
import http.client


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this was desired to be part of the diff.

@gpshead gpshead merged commit ffece55 into python:main Dec 29, 2024
40 checks passed
@gpshead gpshead deleted the urllib-hashlib-test-requirements branch December 29, 2024 06:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
… availability (pythongh-128324)

Puts the _hashlib get_fips_mode logic check into test.support rather than spreading it out among other tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants