gh-128083: Fix macro redefinition warning in clinic. #127950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
skip issue
skip news
needs backport to 3.13
This was referenced Dec 14, 2024
ZeroIntensity
changed the title
|
Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @ZeroIntensity and @encukou, I could not cleanly backport this to |
|
I'll backport this manually later today. Thanks! |
ZeroIntensity
added a commit
to ZeroIntensity/cpython
that referenced
this pull request
Dec 19, 2024
…thonGH-127950) (cherry picked from commit b5d1e45) Co-authored-by: Peter Bierma <[email protected]>
|
GH-128102 is a backport of this pull request to the 3.13 branch. |
erlend-aasland
pushed a commit
that referenced
this pull request
Dec 19, 2024
… (#128102) (cherry picked from commit b5d1e45) Co-authored-by: Peter Bierma <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, gh-127341 wasn't the only issue with getters and setters in clinic. If you define a setter first, then the getter doesn't
#undefthe docstring accordingly.