Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-103484: Fix broken links reported by linkcheck #124169

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Sep 17, 2024

This is another patch required to fix the current state of make linkcheck in Python Docs. This pull request fixes occurrences of "broken" as reported by make linkcheck.

Please backport to 3.13 and 3.12 branches. 3.12 will have one conflict, which can be solved by undoing the change to whatsnew/3.12.rst.

See below the linkcheck occurrences this PR handles:



📚 Documentation preview 📚: https://cpython-previews--124169.org.readthedocs.build/

Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit ab80c6b into python:main Sep 17, 2024
23 checks passed
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Sep 17, 2024
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2024
)

(cherry picked from commit ab80c6b)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2024

GH-124179 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 17, 2024
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Sep 17, 2024
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2024
)

(cherry picked from commit ab80c6b)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 17, 2024

GH-124180 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 17, 2024
@vstinner
Copy link
Member

Merged, thanks!

vstinner pushed a commit that referenced this pull request Sep 17, 2024
…124180)

GH-103484: Fix broken links reported by linkcheck (GH-124169)
(cherry picked from commit ab80c6b)

Co-authored-by: Rafael Fontenelle <[email protected]>
@rffontenelle rffontenelle deleted the rffontenelle-fix-broken-links branch September 21, 2024 23:05
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
…124179)

GH-103484: Fix broken links reported by linkcheck (GH-124169)
(cherry picked from commit ab80c6b)

Co-authored-by: Rafael Fontenelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants