gh-124027: Support Del, PgUp, and PgDn on TERM=vt100 #124028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Fedora's /etc/inputrc:
"\e[5~": history-search-backward
"\e[6~": history-search-forward
"\e[3~": delete-char
Fixes python#124027
hroncok
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
|
The tests added in #123607 already work with those data, so I am unsure how to properly test this. |
pablogsal
changed the title
pablogsal
approved these changes
Sep 13, 2024
|
Thanks @hroncok for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2024
…124028) pyrepl: Support Del, PgUp, and PgDn on TERM=vt100 From Fedora's /etc/inputrc: "\e[5~": history-search-backward "\e[6~": history-search-forward "\e[3~": delete-char Fixes python#124027 (cherry picked from commit f4e5643) Co-authored-by: Miro Hrončok <[email protected]>
|
GH-124029 is a backport of this pull request to the 3.13 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Sep 13, 2024
… (#124029) gh-124027: Support Del, PgUp, and PgDn on TERM=vt100 (GH-124028) pyrepl: Support Del, PgUp, and PgDn on TERM=vt100 From Fedora's /etc/inputrc: "\e[5~": history-search-backward "\e[6~": history-search-forward "\e[3~": delete-char Fixes #124027 (cherry picked from commit f4e5643) Co-authored-by: Miro Hrončok <[email protected]>
|
Thanks for merging. Sorry I forgot the issue number prefix. |
|
No problems! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Fedora's /etc/inputrc:
Fixes #124027