-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116622: Fix testPyObjectPrintOSError on Android #122487
Merged
freakboy3742
merged 3 commits into
python:main
from
mhsmith:android-testPyObjectPrintOSError
Jul 31, 2024
Merged
gh-116622: Fix testPyObjectPrintOSError on Android #122487
freakboy3742
merged 3 commits into
python:main
from
mhsmith:android-testPyObjectPrintOSError
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failure seems unrelated: |
freakboy3742
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoying, but makes sense to me.
Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 31, 2024
…2487) Adds extra handling for way BSD/Android return errors from calls to fwrite. (cherry picked from commit 82db572) Co-authored-by: Malcolm Smith <[email protected]>
GH-122490 is a backport of this pull request to the 3.13 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
Jul 31, 2024
…#122490) gh-116622: Fix testPyObjectPrintOSError on Android (GH-122487) Adds extra handling for way BSD/Android return errors from calls to fwrite. (cherry picked from commit 82db572) Co-authored-by: Malcolm Smith <[email protected]>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Adds extra handling for way BSD/Android return errors from calls to fwrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test, which was added in #98749, was failing on Android as follows:
This was caused by a recently-fixed bug in OpenBSD's libc, on which Android's libc is based. Luckily there's a simple workaround.
This PR also addresses the comment in #121595 about it being inconvenient to build all architectures before running the testbed. The build script now allows architectures to be missing, as long as at least one is present.