Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36007: Bump minimum sphinx version to 1.8 #11887

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Feb 15, 2019

Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@miss-islington
Copy link
Contributor

Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @asottile, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a16ab00c0b8e126ab82e7cb5098af3ea32d315ff 3.7

@miss-islington miss-islington self-assigned this Feb 15, 2019
@asottile asottile deleted the bump_sphinx_36007 branch February 15, 2019 23:45
@asottile
Copy link
Contributor Author

@Mariatta I don't think this needs / should be backported to 3.7 -- the :skipif: patch wasn't afaict

@Mariatta
Copy link
Member

Ah you're right. Not sure why I thought it needs a backport. In that case, we're done here.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants