Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118820: Zero-valued flag enum has no name #118848

Merged
merged 7 commits into from
Jun 19, 2024
Merged

gh-118820: Zero-valued flag enum has no name #118848

merged 7 commits into from
Jun 19, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented May 9, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels May 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review May 9, 2024 15:30
@nineteendo nineteendo requested a review from ethanfurman as a code owner May 9, 2024 15:30
ethanfurman
ethanfurman requested changes May 9, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nineteendo
Copy link
Contributor Author

ethanfurman, I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ethanfurman May 9, 2024 17:10
@TeamSpen210
Copy link

It might be more clear to do Perm(0), since it took me a moment to realise the intersection would exclude everything.

@nineteendo
Copy link
Contributor Author

Note that ...(0) is only used once on the page, ... & ... is used 4 more times. But if Ethan agrees, I'll change it.

ethanfurman
ethanfurman requested changes May 9, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@nineteendo @ethanfurman
Update Doc/howto/enum.rst
d6e95e0 
Co-authored-by: Ethan Furman <[email protected]>
@nineteendo
Copy link
Contributor Author

I have made the requested changes; please review again.

picnixz
picnixz reviewed Jun 9, 2024
View reviewed changes
@ethanfurman ethanfurman merged commit ed5ae6c into python:main Jun 19, 2024
25 checks passed
@nineteendo nineteendo deleted the zeroless-enum-example branch June 19, 2024 20:10
@nineteendo
Copy link
Contributor Author

Thanks Ethan.

@nineteendo
Copy link
Contributor Author

Do we backport this? Or can we close the issue immediately?

@ethanfurman
Copy link
Member

No problem, apologies for the delay. Should probably backport. Adding appropriate labels.

@ethanfurman ethanfurman added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 19, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2024
@nineteendo @picnixz @miss-islington
pythongh-118820: Zero-valued flag enum has no name (pythonGH-118848)
ed82690 
(cherry picked from commit ed5ae6c)

Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2024
@nineteendo @picnixz @miss-islington
pythongh-118820: Zero-valued flag enum has no name (pythonGH-118848)
3e1c23e 
(cherry picked from commit ed5ae6c)

Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2024

GH-120758 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 19, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 19, 2024

GH-120759 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 19, 2024
ethanfurman pushed a commit that referenced this pull request Jun 19, 2024
@miss-islington @nineteendo @picnixz
[3.13] gh-118820: Zero-valued flag enum has no name (GH-118848) (GH-1…
e415d25 
…20759)

gh-118820: Zero-valued flag enum has no name (GH-118848)
(cherry picked from commit ed5ae6c)

Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
ethanfurman pushed a commit that referenced this pull request Jun 19, 2024
@miss-islington @nineteendo @picnixz
[3.12] gh-118820: Zero-valued flag enum has no name (GH-118848) (GH12…
6421db1 
…0758)

gh-118820: Zero-valued flag enum has no name (GH-118848)
(cherry picked from commit ed5ae6c)

Co-authored-by: Nice Zombies <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo @picnixz @mrahtz
pythongh-118820: Zero-valued flag enum has no name (pythonGH-118848)
de58f6d 
Co-authored-by: Bénédikt Tran <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo @picnixz @noahbkim
pythongh-118820: Zero-valued flag enum has no name (pythonGH-118848)
5e756d3 
Co-authored-by: Bénédikt Tran <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @picnixz @estyxx
pythongh-118820: Zero-valued flag enum has no name (pythonGH-118848)
5216e94 
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nineteendo @TeamSpen210 @ethanfurman @picnixz