gh-118608: datetime: Fix use-after-free on embedded CPython #118531
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug build on Windows (and CI: 7bbce38):
At the
Loop #2
, the static types are carried over in the_datetime
module, but theirtp_dict
no longer has valid keys, since all interned strings (keys) are freed after_PyUnicode_ClearInterned()
inunicodeobject.c
is invoked.To check a key without a crash, the following strings need to be statically allocated:
PyMemberDef
arrayPyMethodDef
arrayPyGetSetDef
arraykey
parameters of thePyDict_SetItemString(tp_dict, key, value)
calls.This patch includes the names that are already statically allocated (e.g. getset names).