-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-116731: Fix refleaks in importlib tests #116763
Conversation
b576685
to
b33e4d5
Compare
With these changes, refleaks checks now pass:
|
from importlib.metadata import MetadataPathFinder | ||
MetadataPathFinder().invalidate_caches() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettcannon I included you in the review for this section. Any concerns with adding this hook here?
I believe this build was the one triggered for refleaks. It looks like it may have failed to start. |
This is superseded by a cleaner approach in #116805. I still think |
files()
.test_importlib
started leaking on refleaks #116731