Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113308: Remove some internal parts of uuid module #115934

Merged
merged 9 commits into from
Mar 14, 2024
Merged

gh-113308: Remove some internal parts of uuid module #115934

merged 9 commits into from
Mar 14, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 26, 2024 •
edited by github-actions bot
Loading

Tests do not produce any warnings:

» ./python.exe -m test test_uuid   
Using random seed: 3734037146
0:00:00 load avg: 1.55 Run 1 test sequentially
0:00:00 load avg: 1.55 [1/1] test_uuid

== Tests result: SUCCESS ==

1 test OK.

Total duration: 401 ms
Total tests: run=72 skipped=13
Total test files: run=1/1
Result: SUCCESS

I didn't add any explicit tests for unused deprecated functions. I can, if needed.

📚 Documentation preview 📚: https://cpython-previews--115934.org.readthedocs.build/

@sobolevn sobolevn requested review from gpshead and hugovk February 26, 2024 07:16
@bedevere-app bedevere-app bot mentioned this pull request Feb 26, 2024
Closed
hugovk
hugovk reviewed Feb 26, 2024
View reviewed changes
@sobolevn sobolevn requested a review from hugovk February 26, 2024 09:11
@sobolevn sobolevn changed the title gh-113308: Deprecate some internal parts of uuid module gh-113308: Remove some internal parts of uuid module Mar 3, 2024
hugovk
hugovk reviewed Mar 3, 2024
View reviewed changes
@sobolevn @hugovk
Update Lib/test/test_uuid.py
0eec764 
Co-authored-by: Hugo van Kemenade <[email protected]>
@sobolevn sobolevn requested review from gpshead and hugovk March 13, 2024 06:40
vstinner
vstinner approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn merged commit 61f576a into python:main Mar 14, 2024
31 checks passed
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @hugovk @vstinner
pythongh-113308: Remove some internal parts of uuid module (python#…
c742f43 
…115934)

Co-authored-by: Hugo van Kemenade <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @hugovk @adorilson
pythongh-113308: Remove some internal parts of uuid module (python#…
705e327 
…115934)

Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead gpshead mentioned this pull request Apr 13, 2024
Closed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @hugovk @diegorusso
pythongh-113308: Remove some internal parts of uuid module (python#…
e5561b3 
…115934)

Co-authored-by: Hugo van Kemenade <[email protected]>
@ericfrederich ericfrederich mentioned this pull request Oct 16, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@hugovk hugovk hugovk approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @gpshead @vstinner @hugovk