gh-112075: Add a little specialization thread safety #114768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinoV
force-pushed
the
nogil_dict_module_specialization
branch
from
ded73c4 to
a857147
Compare
DinoV
changed the title
DinoV
force-pushed
the
nogil_dict_module_specialization
branch
from
a857147 to
dc19c16
Compare
colesbury
reviewed
Jan 31, 2024
There was a problem hiding this comment.
This looks okay to me and should not have any effect on the default build.
However, I think we should generally hold off on incremental thread-safety changes to specialization until the dict thread-safe changes are done. I find it hard to tell how these sorts of changes will interact.
Comment on lines
+847
to
+848
| int res; | ||
| Py_BEGIN_CRITICAL_SECTION(dict); |
There was a problem hiding this comment.
I think this might be easier to read if it is refactored out into it's own function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of specializations call into dict apis w/o a lock and are doing multiple reads. This is just a small change to protect those reads with the dict lock.
dictobjects thread-safe in--disable-gilbuilds #112075