-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-110190: Fix ctypes structs with array on Windows ARM64 #114753
Conversation
Fix the same issue of PR python#112959 on Windows ARM64 platform when using MSVC compiler. MSVC predefined platform preprocessor macro is _M_ARM64.
@zooba have a look please. I tested it on my Windows ARM64 VM and it works as expected. I should have spotted initially but my experience with Windows is not that extensive (and at the time I didn't have a machine to test on) :) |
Ooh, yeah, that seems a likely culprit. I'll build and test on my machine to confirm, but glad it's this simple if it is! |
Apologies for the delay, had some infrastructure issues, but the fix looks good. Thanks! |
Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]>
GH-114774 is a backport of this pull request to the 3.11 branch. |
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]>
GH-114775 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]>
(cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]>
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]> Signed-off-by: Michał Górny <[email protected]>
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]> Signed-off-by: Michał Górny <[email protected]>
…onGH-114753) (cherry picked from commit a06b606) Co-authored-by: Diego Russo <[email protected]> Signed-off-by: Michał Górny <[email protected]>
Fix the same issue of PR #112959 on Windows ARM64 platform when using MSVC compiler.
MSVC predefined platform preprocessor macro is _M_ARM64.