Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-110190: Fix ctypes structs with array on Windows ARM64 #114753

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

diegorusso
Copy link
Contributor

@diegorusso diegorusso commented Jan 30, 2024

Fix the same issue of PR #112959 on Windows ARM64 platform when using MSVC compiler.
MSVC predefined platform preprocessor macro is _M_ARM64.

Fix the same issue of PR python#112959 on Windows ARM64 platform when using
MSVC compiler. MSVC predefined platform preprocessor macro is _M_ARM64.
@diegorusso
Copy link
Contributor Author

diegorusso commented Jan 30, 2024

@zooba have a look please. I tested it on my Windows ARM64 VM and it works as expected. I should have spotted initially but my experience with Windows is not that extensive (and at the time I didn't have a machine to test on) :)

@Eclips4 Eclips4 requested a review from zooba January 30, 2024 16:28
@zooba
Copy link
Member

zooba commented Jan 30, 2024

Ooh, yeah, that seems a likely culprit. I'll build and test on my machine to confirm, but glad it's this simple if it is!

@zooba
Copy link
Member

zooba commented Jan 30, 2024

Apologies for the delay, had some infrastructure issues, but the fix looks good. Thanks!

@zooba zooba merged commit a06b606 into python:main Jan 30, 2024
32 checks passed
@zooba zooba added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jan 30, 2024
@miss-islington-app
Copy link

Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @diegorusso for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2024

GH-114774 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 30, 2024
@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jan 30, 2024

GH-114775 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jan 30, 2024
zooba pushed a commit that referenced this pull request Jan 31, 2024
zooba pushed a commit that referenced this pull request Jan 31, 2024
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
…onGH-114753)

(cherry picked from commit a06b606)

Co-authored-by: Diego Russo <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
…onGH-114753)

(cherry picked from commit a06b606)

Co-authored-by: Diego Russo <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
…onGH-114753)

(cherry picked from commit a06b606)

Co-authored-by: Diego Russo <[email protected]>
Signed-off-by: Michał Górny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants