pythongh-109534: close transport if waiter is done

[geraldog]

I'm not able to reproduce #109534 anymore with this fix. Checking asyncio/sslproto.py it seems the waiter is only done on error or connection lost so this seems safe.

• Issue: TLS/SSL asyncio leaks memory  #109534

[cpython-cla-bot]

The following commit authors need to sign the Contributor License Agreement:

• [email protected]

Click the button to sign:

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[gvanrossum]

Checking asyncio/sslproto.py it seems the waiter is only done on error or connection lost so this seems safe.

Are you sure about that? ISTM that the waiter is passed to _SelectorSocketTransport which sets the waiter's result after connection_made() was called. And note how many tests are failing in CI!

[geraldog]

@gvanrossum actually being a RAW (Robert Anton WIlson) head I'm not sure of anything to be sure... but be kind with me and spare me some CI action - I just think I don't need to create the pull requests to annoy the maintainers to get the CI benefit while I chase this horrid bug.

But the code sure is failing to close the transport somewhere! I just don't know if it's python-code side or c-code side?