gh-113208: Mention namespace packages don't require __init__.py #113209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
Unique-Usman
changed the title
CAM-Gerlach
changed the title
|
@hugovk @CAM-Gerlach check this out. |
CAM-Gerlach
added
needs backport to 3.11
CAM-Gerlach
reviewed
Dec 16, 2023
There was a problem hiding this comment.
Thanks, @Unique-Usman . I added one suggestion to fix a typo; apply it by clicking Commit Suggestion, or together with others by going to the Files changed tab, clicking Add suggestion to batch for each suggestion, and then Commit. Otherwise, LGTM as far as my input goes
Co-authored-by: C.A.M. Gerlach <[email protected]>
|
Thanks! |
|
Thanks @Unique-Usman for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-113276 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 19, 2023
…pythonGH-113209) (cherry picked from commit d71fcde) Co-authored-by: Unique-Usman <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
|
GH-113277 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 19, 2023
…pythonGH-113209) (cherry picked from commit d71fcde) Co-authored-by: Unique-Usman <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Dec 19, 2023
GH-113209) (#113277) Co-authored-by: Unique-Usman <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Dec 19, 2023
GH-113209) (#113276) Co-authored-by: Unique-Usman <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
…python#113209) Co-authored-by: C.A.M. Gerlach <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…python#113209) Co-authored-by: C.A.M. Gerlach <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…python#113209) Co-authored-by: C.A.M. Gerlach <[email protected]>
merwok
reviewed
Jan 24, 2025
| @@ -437,7 +437,8 @@ When importing the package, Python searches through the directories on | |||
| ``sys.path`` looking for the package subdirectory. | |||
|
|
|||
| The :file:`__init__.py` files are required to make Python treat directories | |||
| containing the file as packages. This prevents directories with a common name, | |||
| containing the file as packages (unless using a :term:`namespace package`, a | |||
| relatively advanced feature). This prevents directories with a common name, | |||
| such as ``string``, from unintentionally hiding valid modules that occur later | |||
There was a problem hiding this comment.
So… this line is not true anymore 😢
There was a problem hiding this comment.
Hi @merwok, could you provide a reference to the updated way, I can open a pr for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__.py files are required to make Python treat directories containing the file as packages.might be confusing #113208📚 Documentation preview 📚: https://cpython-previews--113209.org.readthedocs.build/