gh-111928: make "memo" dict local to scan_once call #112005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aisk
commented
Nov 12, 2023
•
aisk
commented
- Issue: json: make "memo" dict local to scan_once call #111928
|
Thanks for the PR! This looks okay, but I worry there will be a performance regression. Do you know how much of a hit performance takes with this approach? |
corona10
reviewed
Nov 12, 2023
There was a problem hiding this comment.
Would you like to add @colesbury as co-author since the PR is cherry-picked from his own repo?
Oh you did already.
| @@ -0,0 +1 @@ | |||
| Make the ``memo`` dict thread safe without the GIL in :mod:`json`. | |||
There was a problem hiding this comment.
NEWS.d is not needed since there is no user side changes.
colesbury
changed the title
colesbury
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
This lgtm.
@Fidget-Spinner, performance impact is <1% for parsing tiny strings of JSON (and less for larger JSON strings).
|
Meant to link to a quick and dirty JSON benchmark https://gist.github.com/colesbury/dd888920a1eacb97794fb6be2446dc10: |
corona10
approved these changes
Nov 13, 2023
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…12005) Co-authored-by: Sam Gross <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…12005) Co-authored-by: Sam Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.