Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111881: Use lazy import in test.support #111885

Merged
merged 1 commit into from
Nov 9, 2023
Merged

gh-111881: Use lazy import in test.support #111885

merged 1 commit into from
Nov 9, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 9, 2023 •
edited by bedevere-app bot
Loading

  • Import lazily getpass in test.support
  • Only import ctypes on Windows in test.support.os_helper.

@vstinner
pythongh-111881: Use lazy import in test.support
9c55fe1 
* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.
@vstinner vstinner added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 9, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2023
Closed
@vstinner vstinner merged commit 0372e3b into python:main Nov 9, 2023
27 checks passed
@vstinner vstinner deleted the import_support branch November 9, 2023 14:38
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0372e3b02a7e3dc1c564dba94dcd817c5472b04f 3.12

@vstinner
Copy link
Member Author

vstinner commented Nov 9, 2023

Merged, thanks for the review @AlexWaygood.

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0372e3b02a7e3dc1c564dba94dcd817c5472b04f 3.11

@vstinner vstinner removed needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Nov 9, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 9, 2023

GH-111890 is a backport of this pull request to the 3.12 branch.

vstinner added a commit to vstinner/cpython that referenced this pull request Nov 9, 2023
@vstinner
pythongh-111881: Use lazy import in test.support (python#111885)
2a5829b 
* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.

(cherry picked from commit 0372e3b)
vstinner added a commit that referenced this pull request Nov 9, 2023
@vstinner
[3.12] gh-111881: Use lazy import in test.support (#111885) (#111890)
e983ca8 
gh-111881: Use lazy import in test.support (#111885)

* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.

(cherry picked from commit 0372e3b)
@vstinner vstinner mentioned this pull request Nov 9, 2023
Merged
vstinner added a commit that referenced this pull request Nov 9, 2023
@vstinner
[3.11] gh-111881: Use lazy import in test.support (#111885) (#111890) (…
f108976 
…#111902)

[3.12] gh-111881: Use lazy import in test.support (#111885) (#111890)

gh-111881: Use lazy import in test.support (#111885)

* Import lazily getpass in test.support

Backport to 3.11: test.support.os_helper is unchanged.

(cherry picked from commit 0372e3b)
(cherry picked from commit e983ca8)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-111881: Use lazy import in test.support (python#111885)
fe5a1a7 
* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-111881: Use lazy import in test.support (python#111885)
9cd1978 
* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@vstinner vstinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @AlexWaygood