Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94808: Add coverage test for number check #111445

Merged
merged 5 commits into from
Oct 29, 2023
Merged

gh-94808: Add coverage test for number check #111445

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
91daa4d
Add aoverage test for number check
ekohilas Oct 29, 2023
08c5af9
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 29, 2023
9baf417
Update Lib/test/test_capi/test_abstract.py
ekohilas Oct 29, 2023
445bcc0
Update Lib/test/test_capi/test_abstract.py
ekohilas Oct 29, 2023
fd3d99c
Update Lib/test/test_capi/test_abstract.py
ekohilas Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_capi/test_abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,11 @@ def test_sequence_tuple(self):
self.assertRaises(TypeError, xtuple, 42)
self.assertRaises(SystemError, xtuple, NULL)

def test_number_check_complex(self):
number_check = _testcapi.number_check
ekohilas marked this conversation as resolved.
Show resolved Hide resolved
self.assertTrue(number_check(1 + 1j))
ekohilas marked this conversation as resolved.
Show resolved Hide resolved

ekohilas marked this conversation as resolved.
Show resolved Hide resolved


if __name__ == "__main__":
unittest.main()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2023-10-29-05-41-47.gh-issue-94808.0FHZfr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add a C API test for the PyNumber_Check function.
Copy link
Member

@corona10 corona10 Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please remove this file too :)

7 changes: 7 additions & 0 deletions Modules/_testcapi/abstract.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@ object_delattrstring(PyObject *self, PyObject *args)
RETURN_INT(PyObject_DelAttrString(obj, attr_name));
}

static PyObject *
number_check(PyObject *self, PyObject *obj)
{
NULLABLE(obj);
return PyBool_FromLong(PyNumber_Check(obj));
}

static PyObject *
mapping_check(PyObject *self, PyObject *obj)
Expand Down Expand Up @@ -623,6 +629,7 @@ static PyMethodDef test_methods[] = {
{"object_delattr", object_delattr, METH_VARARGS},
{"object_delattrstring", object_delattrstring, METH_VARARGS},

{"number_check", number_check, METH_O},
{"mapping_check", mapping_check, METH_O},
{"mapping_size", mapping_size, METH_O},
{"mapping_length", mapping_length, METH_O},
Expand Down