Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-111062: Apply reusable workflow for the Linux CI #111440

Closed
wants to merge 8 commits into from
Closed

GH-111062: Apply reusable workflow for the Linux CI #111440

wants to merge 8 commits into from

Conversation

NCLI
Copy link
Contributor

@NCLI NCLI commented Oct 29, 2023 •
edited by bedevere-app bot
Loading

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 29, 2023 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

corona10
corona10 reviewed Oct 29, 2023
View reviewed changes
.github/workflows/build.yml Outdated
- name: Remount sources writable for tests
# some tests write to srcdir, lack of pyc files slows down testing
run: sudo mount $CPYTHON_RO_SRCDIR -oremount,rw
- name: Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we don't need to run test code at this moment :)

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@NCLI NCLI changed the title No gil workflow GH-111062 No gil workflow for CI/CD Oct 29, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 29, 2023
Closed
@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@corona10 corona10 changed the title GH-111062 No gil workflow for CI/CD GH-111062: Apply Reusable workflow for the Linux CI Oct 29, 2023
@corona10 corona10 changed the title GH-111062: Apply Reusable workflow for the Linux CI GH-111062: Apply reusable workflow for the Linux CI Oct 29, 2023
@dimaqq
Copy link
Contributor

dimaqq commented Oct 29, 2023 •
edited
Loading

Is this superseded by #111446 now?

@dimaqq
Copy link
Contributor

dimaqq commented Oct 29, 2023

"nogil" -> "free-threaded"
let's build this on top of #111446

@corona10
Copy link
Member

Duplicated with #111452

@corona10 corona10 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 left review comments

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
awaiting review DO-NOT-MERGE skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NCLI @dimaqq @corona10