-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-34977: Add Windows App Store package #11027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the venv and tests change into a separated PR.
When you're done making the requested changes, leave the comment: |
Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-) |
How do you trigger a custom build these days? I couldn't find the UI. |
It's basically just a Git push to the right branch:
See https://devguide.python.org/buildbots/#custom-builders for more info. Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-) |
I have made the requested changes; please review again |
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor points, but generally this looks OK to me.
Also adds the PC/layout script for generating layouts on Windows.
Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.
https://bugs.python.org/issue34977