Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-34977: Add Windows App Store package #11027

Merged
merged 6 commits into from
Dec 11, 2018
Merged

bpo-34977: Add Windows App Store package #11027

merged 6 commits into from
Dec 11, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Dec 7, 2018

Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.

https://bugs.python.org/issue34977

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the venv and tests change into a separated PR.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-)
https://bugs.python.org/issue34977#msg331322

@zooba
Copy link
Member Author

zooba commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

How do you trigger a custom build these days? I couldn't find the UI.

It's basically just a Git push to the right branch:

$ git push upstream <local_branch_name>:buildbot-custom

See https://devguide.python.org/buildbots/#custom-builders for more info.

Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-)

zooba added a commit to zooba/cpython that referenced this pull request Dec 10, 2018
@zooba
Copy link
Member Author

zooba commented Dec 10, 2018

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor points, but generally this looks OK to me.

@zooba zooba merged commit 0cd6391 into python:master Dec 11, 2018
@zooba zooba deleted the bpo34977 branch December 11, 2018 02:53
zooba added a commit that referenced this pull request Dec 11, 2018
Also adds the PC/layout script for generating layouts on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants