gh-108303: Move all certificates to Lib/test/certdata/
#109489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested review from
a team,
vsajip,
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
Aaaand it broke :( |
sobolevn
force-pushed
the
issue-108303-certs
branch
from
0068ea7 to
8ae8733
Compare
|
LGTM, merged, thanks @sobolevn :-) |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2023
…nGH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-109682 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2023
…nGH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-109683 is a backport of this pull request to the 3.11 branch. |
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
vstinner
pushed a commit
that referenced
this pull request
Oct 10, 2023
…09489) (#109682) * gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <[email protected]> Python 3.12 backport: update also `test_nntplib`. Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: T. Wouters <[email protected]>
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2023
…pythonGH-109489) (pythonGH-109682) * pythongh-108303: Move all certificates to `Lib/test/certdata/` (pythonGH-109489) (cherry picked from commit e57ecf6) Co-authored-by: Nikita Sobolev <[email protected]> Python 3.12 backport: update also `test_nntplib`. (cherry picked from commit c2d542b) Co-authored-by: Miss Islington (bot) <[email protected]> Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: T. Wouters <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Oct 10, 2023
GH-109489) (GH-109682) (#110646) [3.12] gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (GH-109682) * gh-108303: Move all certificates to `Lib/test/certdata/` (GH-109489) (cherry picked from commit e57ecf6) Python 3.12 backport: update also `test_nntplib`. (cherry picked from commit c2d542b) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: T. Wouters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one: I moved all
.pemandsslrelated files to a single test helper diractory:I haven't touched their contents or permissions (at least I hope so), so let's what the CI will say :)
I've also checked that
Lib/test/certdata/make_ssl_certs.pyscript still works. It produces new certificates as it should.