Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108747: Add unit tests for site.{usercustomize,sitecustomize} hooks #109470

Merged
merged 12 commits into from
Oct 18, 2023

Conversation

csm10495
Copy link
Contributor

@csm10495 csm10495 commented Sep 15, 2023

@csm10495
Copy link
Contributor Author

@hauntsaninja, I think you were the last person to edit site.py. Any chance I can have a review? Thanks!

@csm10495
Copy link
Contributor Author

Friendly ping @hauntsaninja. Thanks.

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test! Not sure that I'm the right person to review, but left a comment :-)

@csm10495
Copy link
Contributor Author

Updated. @hauntsaninja if you have someone else in mind, feel free to add them. Thanks still.

Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja merged commit 738574f into python:main Oct 18, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants