-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-109054: Document configure variables #109224
Conversation
9b3fc31
to
3485011
Compare
I'm not sure if adding a new dedicated I chose to use I used Initially, I just wrote this PR to document |
I reorganized the doc. I'm not sure between cc @hugovk |
@erlend-aasland: it seems like the whole "3.3.4. Libraries Options" section is new in Python 3.11, all xxx_CFLAGS and xxx_LIBS, no? |
PROFILE_TASK was added in Python 3.8. |
Yes, it came with the setup.py migration we did. |
Doc/using/configure.rst
Outdated
Name for machine-dependent library files. | ||
|
||
|
||
Libraries Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Third-party dependencies or Options for third-party dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for "Options for third-party dependencies".
@erlend-aasland: I updated my PR, would you mind to review it again? |
Doc/using/configure.rst
Outdated
.. cmdoption:: LIBATOMIC | ||
|
||
Linker flags when ``cpython/pyatomic.h`` header file is used. | ||
|
||
Default: ``LIBATOMIC='-latomic'`` if ``libatomic`` is needed, or | ||
``LIBATOMIC=''`` otherwise (also the default when Python is cross-compiled). | ||
|
||
.. versionadded:: 3.13 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going away with #109344:
.. cmdoption:: LIBATOMIC | |
Linker flags when ``cpython/pyatomic.h`` header file is used. | |
Default: ``LIBATOMIC='-latomic'`` if ``libatomic`` is needed, or | |
``LIBATOMIC=''`` otherwise (also the default when Python is cross-compiled). | |
.. versionadded:: 3.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that you want me to remove this variable in the doc, so I removed it.
29756c5
to
dc0ebcd
Compare
Oh sorry for the noise, I tried a Git tool which messed up with my PR. I fixed my PR. |
f0ce11d
to
2796022
Compare
PR rebased on the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the PR focused and handle capitalization issues in a separate PR.
New titles should follow the existing conventions, even if it doesn't match the preferred capitalization specified by the devguide. A follow-up PR can fix it.
b5eda29
to
9780c71
Compare
Hum, ok, I reverted these changes. I didn't expect that changing a few titles would be so controversial :-) |
9780c71
to
4993499
Compare
4993499
to
8ce10b5
Compare
Co-authored-by: Ezio Melotti <[email protected]>
@erlend-aasland @hugovk @ezio-melotti: I rebased my PR on the main branch, squashed commits, I reverted title casing change (don't use Titlecase Anymore). Please review the updated PR. @ezio-melotti: I applied your sugsestions to use |
Looks good, although I'll leave approval for someone who knows about these flags 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Sphinx-wise. (But same caveat as Hugo wrt the flags)
A
Co-authored-by: Ezio Melotti <[email protected]>
Thanks for the reviews. If someone has more remarks, feel free to propose a PR :-) |
LGTM! Thanks for documenting these things. |
📚 Documentation preview 📚: https://cpython-previews--109224.org.readthedocs.build/