Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-108223: Document --disable-gil flag in configure #108236

Merged
merged 4 commits into from
Aug 21, 2023
Merged

gh-108223: Document --disable-gil flag in configure #108236

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c43a5a
gh-108223: Document --disable-gil flag in configure
colesbury Aug 21, 2023
0a8d23a
Update Doc/using/configure.rst
colesbury Aug 21, 2023
036157c
Add link to PEP
colesbury Aug 21, 2023
72b4900
Update Doc/using/configure.rst
vstinner Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Doc/using/configure.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,15 @@ General Options

.. versionadded:: 3.11

.. cmdoption:: --disable-gil

Enables experimental support for running Python without the
vstinner marked this conversation as resolved.
Show resolved Hide resolved
:term:`global interpreter lock` (GIL).
Copy link
Member

@AA-Turner AA-Turner Aug 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a warning admonition emphasising that this is experimental, in development, etc -- mainly to preempt a random twitter recommendation that "No GIL has now been implemented! Rebuild your Python today with --disable-gil..."

Perhaps a fear that won't materialise, though!

A

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with adding whatever text you think is helpful. I expect to revisit and update this later in the development cycle based on what's actually integrated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam! Victor's simpler change I think is better for now--we don't really advertise building from source to end-users anyway, so I on reflection I think we don't need a high level of warning here.

A


See :pep:`703` "Making the Global Interpreter Lock Optional in CPython".

.. versionadded:: 3.13

WebAssembly Options
-------------------

Expand Down