gh-106368: Argument clinic: improve coverage for self.valid_line()
calls
#107641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The early return in
self.state_modulename_name()
is unreachable, asstate_modulename_name()
is only ever called fromstate_dsl_start
, and the first thingstate_dsl_start
does is check whether theline
is valid:cpython/Tools/clinic/clinic.py
Lines 4655 to 4657 in 321f0f7
There are two other
if not self.valid_line(line)
branches inclinic.py
which are reachable, but are uncovered:cpython/Tools/clinic/clinic.py
Lines 5323 to 5330 in 321f0f7
cpython/Tools/clinic/clinic.py
Lines 5304 to 5306 in 321f0f7
Add a test that covers both of them.