-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some GC stats to Py_STATS #107581
Add some GC stats to Py_STATS #107581
Conversation
I have already a PR open for this: I would prefer to complete that one if possible |
@pablogsal If you need additional timings, then adding an |
@pablogsal There is some overlap between this PR and #100958, but #100958 has been open since January, and I'm worried that we will have no stats at all for months. As an aside: |
Ok let's merge this PR and let's refine the other one 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This partly duplicates the stats from the GC module, but serves a different purpose, as it allows us to gather stats that would be too expensive to gather in a release build.
The stats:
https://github.com/faster-cpython/benchmarking/blob/main/results/bm-20230730-3.13.0a0-8bc0926/bm-20230730-azure-x86_64-faster%252dcpython-gc_stats-3.13.0a0-8bc0926-pystats.md