Clarify state of CancelledError in doc #106453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristjanvalur
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
gvanrossum
added
needs backport to 3.11
|
Thanks @kristjanvalur for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @kristjanvalur for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry @kristjanvalur and @gvanrossum, I had trouble checking out the |
|
GH-106454 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
added
needs backport to 3.11
|
Thanks @kristjanvalur for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-106456 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2023
This change makes it explicit that asyncio.CancelledError is not a subclass of Exception. (cherry picked from commit 12a9813) Co-authored-by: Kristján Valur Jónsson <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Jul 5, 2023
* main: (39 commits) pythongh-102542 Remove unused bytes object and bytes slicing (python#106433) Clarify state of CancelledError in doc (python#106453) pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449) pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443) tp_flags docs: fix indentation (python#106420) pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437) pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415) pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431) pythongh-104050: Annotate toplevel functions in clinic.py (python#106435) pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434) Add some codeowners for `Tools/clinic/` (python#106430) pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423) pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414) pythongh-106162: array: suppress warning in test_array (python#106404) pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425) pythonGH-106360: Support very basic superblock introspection (python#106422) pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408) pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401) pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407) pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367) ...
gvanrossum
pushed a commit
that referenced
this pull request
Jul 5, 2023
Clarify state of CancelledError in doc (GH-106453) This change makes it explicit that asyncio.CancelledError is not a subclass of Exception. (cherry picked from commit 12a9813) Co-authored-by: Kristján Valur Jónsson <[email protected]>
11 tasks
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 6, 2023
Clarify state of CancelledError in doc (GH-106453) This change makes it explicit that asyncio.CancelledError is not a subclass of Exception. (cherry picked from commit 12a9813) Co-authored-by: Kristján Valur Jónsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it explicit that
asyncio.CancelledErroris not a subclass ofException.The previous wording technically allowed for the interpretation that it might also be an
Exception, and that this were therefore somehow interpretation-defined. This change corresponds to the text in the "What's new in 3.8" section.📚 Documentation preview 📚: https://cpython-previews--106453.org.readthedocs.build/