Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106392: Fix inconsistency in deprecation warnings #106436

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

wjandrea
Copy link
Contributor

@wjandrea wjandrea commented Jul 4, 2023

They used "datetime" to refer to both the object and the module

They used "datetime" to refer to both the object and the module
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja enabled auto-merge (squash) September 1, 2023 22:00
@hauntsaninja hauntsaninja merged commit d5c5d4b into python:main Sep 1, 2023
@miss-islington
Copy link
Contributor

Thanks @wjandrea for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-108792 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Sep 1, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 1, 2023
…106436)

They used "datetime" to refer to both the object and the module.
(cherry picked from commit d5c5d4b)

Co-authored-by: William Andrea <[email protected]>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO 3.x has failed when building commit d5c5d4b.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/503/builds/3831) and take a look at the build logs.
  4. Check if the failure is related to this commit (d5c5d4b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/503/builds/3831

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

438 tests OK.

10 slowest tests:

  • test_math: 3 min 4 sec
  • test_hashlib: 1 min 33 sec
  • test.test_multiprocessing_forkserver.test_processes: 1 min 21 sec
  • test_venv: 1 min 12 sec
  • test.test_concurrent_futures.test_wait: 1 min 12 sec
  • test.test_multiprocessing_spawn.test_processes: 1 min 8 sec
  • test.test_multiprocessing_spawn.test_misc: 1 min 7 sec
  • test_unparse: 1 min 3 sec
  • test.test_concurrent_futures.test_process_pool: 1 min 3 sec
  • test_tokenize: 57.8 sec

1 test altered the execution environment:
test.test_concurrent_futures.test_process_pool

23 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_idle test_ioctl test_kqueue test_launcher test_perf_profiler
test_smtpnet test_sqlite3 test_ssl test_startfile test_tcl
test_tkinter test_ttk test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 5 min 48 sec

Click to see traceback logs
remote: Enumerating objects: 14, done.        
remote: Counting objects:   7% (1/14)        
remote: Counting objects:  14% (2/14)        
remote: Counting objects:  21% (3/14)        
remote: Counting objects:  28% (4/14)        
remote: Counting objects:  35% (5/14)        
remote: Counting objects:  42% (6/14)        
remote: Counting objects:  50% (7/14)        
remote: Counting objects:  57% (8/14)        
remote: Counting objects:  64% (9/14)        
remote: Counting objects:  71% (10/14)        
remote: Counting objects:  78% (11/14)        
remote: Counting objects:  85% (12/14)        
remote: Counting objects:  92% (13/14)        
remote: Counting objects: 100% (14/14)        
remote: Counting objects: 100% (14/14), done.        
remote: Compressing objects:  11% (1/9)        
remote: Compressing objects:  22% (2/9)        
remote: Compressing objects:  33% (3/9)        
remote: Compressing objects:  44% (4/9)        
remote: Compressing objects:  55% (5/9)        
remote: Compressing objects:  66% (6/9)        
remote: Compressing objects:  77% (7/9)        
remote: Compressing objects:  88% (8/9)        
remote: Compressing objects: 100% (9/9)        
remote: Compressing objects: 100% (9/9), done.        
remote: Total 9 (delta 7), reused 1 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out 'd5c5d4bfd3260219397326795d3b2ff62a9ab8cb'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at d5c5d4b... gh-106392: Fix inconsistency in deprecation warnings (#106436)
Switched to and reset branch 'main'

make: *** [Makefile:2025: buildbottest] Error 3

@wjandrea wjandrea deleted the patch-2 branch September 2, 2023 20:06
Yhg1s pushed a commit that referenced this pull request Sep 2, 2023
… (#108792)

gh-106392: Fix inconsistency in deprecation warnings (GH-106436)

They used "datetime" to refer to both the object and the module.
(cherry picked from commit d5c5d4b)

Co-authored-by: William Andrea <[email protected]>
hauntsaninja added a commit to hauntsaninja/cpython that referenced this pull request Jan 30, 2024
Previously python#106436 fixed consistency within the suggested replacement,
but not in the entire message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants