gh-106368: Increase Argument Clinic test coverage #106369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for 'self' and 'defining_class' converter requirements.
erlend-aasland
added
skip news
needs backport to 3.11
|
I consider this an uncontroversial change; will merge when CI is green. |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @erlend-aasland, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2023
) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-106370 is a backport of this pull request to the 3.12 branch. |
|
GH-106374 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Jul 3, 2023
…n#106369) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Jul 3, 2023
…106370) Add tests for 'self' and 'defining_class' converter requirements. (cherry picked from commit 7f4c812) Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for 'self' and 'defining_class' converter requirements.