gh-89392: Make test_decimal discoverable #106209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
tests
serhiy-storchaka
force-pushed
the
test_decimal
branch
2 times, most recently
from
6dbb8a5 to
9e7f09a
Compare
zware
approved these changes
Jun 28, 2023
serhiy-storchaka
force-pushed
the
test_decimal
branch
from
9e7f09a to
9b8c95e
Compare
serhiy-storchaka
force-pushed
the
test_decimal
branch
from
9b8c95e to
196fc8a
Compare
serhiy-storchaka
force-pushed
the
test_decimal
branch
from
196fc8a to
ce3f424
Compare
erlend-aasland
approved these changes
Jun 29, 2023
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry @serhiy-storchaka, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 29, 2023
(cherry picked from commit 0e24499) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-106229 is a backport of this pull request to the 3.11 branch. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 29, 2023
(cherry picked from commit 0e24499) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-106230 is a backport of this pull request to the 3.12 branch. |
|
Only took 10 years, but we got there! Thanks Serhiy :) |
ambv
pushed a commit
that referenced
this pull request
Jul 5, 2023
ambv
pushed a commit
that referenced
this pull request
Jul 5, 2023
(cherry picked from commit 0e24499) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very peculiar test file. It provides additional CLI interface and programming interface which accept options to control what to test what print during testing.
This PR is different from Zachary's patch for #64207. It only makes minimal changes necessary to make tests discoverable, use standard unittest methods to collect and run tests, and avoid changing the current behavior. The code of the module can be improved further, but this is out of the scope of this PR.
The two modified tests depended on the order in which the tests were ran.