Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDLE: Condense run.main threading.Thread start. #106125

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

terryjreedy
Copy link
Member

Use daemon argument added in 3.3 and directly call .start. Remove now unused 'sockthread' name.

Use daemon argument added in 3.3 and directly call .start.
Remove now unused 'sockthread' name.
@terryjreedy terryjreedy added stdlib Python modules in the Lib dir topic-IDLE needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 27, 2023
@terryjreedy terryjreedy self-assigned this Jun 27, 2023
@terryjreedy terryjreedy merged commit eaa1eae into python:main Jun 27, 2023
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-106153 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2023
Use daemon argument added in 3.3 and directly call .start.
Remove now unused 'sockthread' name.
(cherry picked from commit eaa1eae)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 27, 2023
@terryjreedy terryjreedy added needs backport to 3.12 bug and security fixes and removed needs backport to 3.12 bug and security fixes labels Jun 27, 2023
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106154 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2023
Use daemon argument added in 3.3 and directly call .start.
Remove now unused 'sockthread' name.
(cherry picked from commit eaa1eae)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 27, 2023
@python python deleted a comment from miss-islington Jun 27, 2023
@terryjreedy terryjreedy deleted the daemon branch June 27, 2023 17:15
terryjreedy added a commit that referenced this pull request Jun 27, 2023
…106154)

IDLE: Condense run.main threading.Thread start. (GH-106125)

Use daemon argument added in 3.3 and directly call .start.
Remove now unused 'sockthread' name.
(cherry picked from commit eaa1eae)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Jun 27, 2023
…106153)

IDLE: Condense run.main threading.Thread start. (GH-106125)

Use daemon argument added in 3.3 and directly call .start.
Remove now unused 'sockthread' name.
(cherry picked from commit eaa1eae)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants