Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105724: Add location information to assert errors #105935

Merged
merged 5 commits into from
Aug 16, 2023
Merged

gh-105724: Add location information to assert errors #105935

merged 5 commits into from
Aug 16, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jun 20, 2023 •
edited by bedevere-bot
Loading

New error message for assert 1 > 2 is:

Traceback (most recent call last):
  File "/Users/sobolev/Desktop/cpython/ex.py", line 1, in <module>
    assert 1 > 2
           ^^^^^
AssertionError

I've also included test cases where assert takes multiple lines.

@bedevere-bot bedevere-bot mentioned this pull request Jun 20, 2023
Open
markshannon
markshannon approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@markshannon
Copy link
Member

test_multiline_assert in test_compile needs to be updated, otherwise LGTM.

iritkatriel
iritkatriel reviewed Jun 20, 2023
View reviewed changes
Lib/test/test_exceptions.py
),
('assert 1 > 2 and 3 > 2',
[
' assert 1 > 2 and 3 > 2',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if it was possible to show which of these has failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be. But that's for another PR, IMO.
I'll elaborate on the issue.

@sobolevn sobolevn requested a review from markshannon June 23, 2023 17:00
@markshannon markshannon merged commit bdd8ddf into python:main Aug 16, 2023
fnordahl added a commit to fnordahl/ovs that referenced this pull request Apr 8, 2024
@fnordahl
tests: Fix compatibility issue with Python 3.13 in vlog.at.
e3ed764 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034
Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
ovsrobot pushed a commit to ovsrobot/ovs that referenced this pull request Apr 8, 2024
@fnordahl @ovsrobot
tests: Fix compatibility issue with Python 3.13 in vlog.at.
58f8659 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034
Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: 0-day Robot <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
9185793 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
a685231 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
fdc4504 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
ac31976 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
edfb2e0 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
igsilya pushed a commit to igsilya/ovs that referenced this pull request Apr 9, 2024
@fnordahl @igsilya
tests: Fix compatibility issue with Python 3.13 in vlog.at.
fc2b1ad 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
roseoriorden pushed a commit to roseoriorden/ovs that referenced this pull request Jul 1, 2024
@fnordahl @roseoriorden
tests: Fix compatibility issue with Python 3.13 in vlog.at.
53844e4 
The vlog - Python3 test makes use of output from Python
Tracebacks in its test assertion.

In Python 3.13 a line with tophat (``^``) markers is added below
Tracebacks from calls to assert [0], which makes the test fail.
This change of behavior is also backported to the Python 3.12 and
3.11 stable branches [1].

Strip lines containing one or more occurrence of the ``^``
character from the output before performing the test assertions.

0: python/cpython#105935
1: python/cpython#116034

Reported-at: https://launchpad.net/bugs/2060434
Signed-off-by: Frode Nordahl <[email protected]>
Signed-off-by: Ilya Maximets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @markshannon @iritkatriel @bedevere-bot